[BUILD] Visual Studio GMOCK_LIB issues and explicit c++17

bkuschel commented 18 hours ago

Change in PR #3106 broke MSVC build. GMOCK_LIB-NOTFOUND from cmake.
In some cases (unsure why), c++17 has to be set explicitly for MSVC

Changes

Copy over similar working code into cmake files dealing with GMOCK_LIB
Explicitly add c++17 support for MSVC

For significant contributions please make sure you have completed the following items:

[ ] CHANGELOG.md updated for non-trivial changes
[ ] Unit tests have been added
[ ] Changes in public API reviewed

netlify[bot] commented 18 hours ago

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name	Link
Latest commit	c280540e0507d3aa7311b7c6fe481767b6e1ff17
Latest deploy log	https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/674062cdc77dfe0008d323f5

codecov[bot] commented 9 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.86%. Comparing base (fe68d51) to head (c280540).

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3158/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #3158 +/- ## ======================================= Coverage 87.86% 87.86% ======================================= Files 195 195 Lines 6151 6151 ======================================= Hits 5404 5404 Misses 747 747 ```

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

open-telemetry / opentelemetry-cpp