search

open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
890 stars 426 forks source link

[BUILD] Do not set OTELCPP_PROTO_PATH in the CMake cache #3160

Closed marcalff closed 1 day ago

marcalff commented 3 days ago

Do not set OTELCPP_PROTO_PATH in the CMake cache.

This is an oversight from:

Setting OTELCPP_PROTO_PATH in the cache prevents to use this flag as intended.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

netlify[bot] commented 3 days ago

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
Latest commit 2440bc8af4c8150752b656e2da0ce0a8316ae524
Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6743742e397e5e000815215d
codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.86%. Comparing base (fcdd526) to head (2440bc8). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3160/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #3160 +/- ## ======================================= Coverage 87.86% 87.86% ======================================= Files 195 195 Lines 6151 6151 ======================================= Hits 5404 5404 Misses 747 747 ```

🚨 Try these New Features: