search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
476 stars 283 forks source link

Metric instrumentation for SQLClient #1738

Open cijothomas opened 3 years ago

cijothomas commented 3 years ago

Similar to: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs

No semantic conventions exist as of today for db, but can still do a basic sql call duration metric. The instrumentations are not stable release anyway, so we can make changes as spec evolves. The goal is to get some metrics flowing automatically for libraries which already have traces enabled.

cijothomas commented 3 years ago

https://github.com/open-telemetry/opentelemetry-specification/pull/2070/files

pantosha commented 1 year ago

https://github.com/open-telemetry/opentelemetry-specification/pull/2070/files

@cijothomas are you going to merge this PR?

cijothomas commented 1 year ago

https://github.com/open-telemetry/opentelemetry-specification/pull/2070/files

@cijothomas are you going to merge this PR?

I am not.

pantosha commented 1 year ago

Oh, sorry, I missed that this is a link to a pull request with a convention. Thank you for the fast answer 😊