search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
470 stars 279 forks source link

Metric instrumentation for Redis client #1742

Open cijothomas opened 2 years ago

cijothomas commented 2 years ago

Similar to: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs

cijothomas commented 2 years ago

spec incoming: https://github.com/open-telemetry/opentelemetry-specification/pull/2070/files

tiagodaraujo commented 3 months ago

I opened the PR #1982 to resolve this issue, I don't know if it was the best process. I added 3 new metrics with the same tracing attributes that follow the semantic convention.

Can anyone help me to understand the next steps or even what steps I skipped?