search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
421 stars 251 forks source link

[Instrumentation.AWS] Update AWS SDK Activity Tags (#1857) #1865

Closed yiran29 closed 2 weeks ago

yiran29 commented 3 weeks ago

Based on Opentelemetry Semantic Conventions for AWS SDK: https://opentelemetry.io/docs/specs/semconv/cloud-providers/aws-sdk, update Activity Tags for rpc.service, rpc.system, rpc.method.

Fixes #1857

Changes

Currently AWS SDK instrumentation did not set RPC Activity Tags as mentioned in https://opentelemetry.io/docs/specs/semconv/cloud-providers/aws-sdk/, this change will add missing tags. Changes have been tested with OpenTelemetry.Instrumentation.AWS.Tests

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed

The committers listed above are authorized under a signed CLA.

vishweshbankwar commented 3 weeks ago

@yiran29 - Could you please sign the CLA? https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1865#issuecomment-2148213537

birojnayak commented 2 weeks ago

@ppittle @Kielek could you guys please review soon ?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.56%. Comparing base (71655ce) to head (fc38dd1). Report is 298 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1865/graphs/tree.svg?width=650&height=150&src=pr&token=DG2DEROH83&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #1865 +/- ## =========================================== + Coverage 73.91% 87.56% +13.64% =========================================== Files 267 12 -255 Lines 9615 201 -9414 =========================================== - Hits 7107 176 -6931 + Misses 2508 25 -2483 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1865/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests-Instrumentation.AWS](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1865/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `87.56% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1865?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...on.AWS/Implementation/AWSTracingPipelineHandler.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1865?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AWS%2FImplementation%2FAWSTracingPipelineHandler.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFXUy9JbXBsZW1lbnRhdGlvbi9BV1NUcmFjaW5nUGlwZWxpbmVIYW5kbGVyLmNz) | `85.85% <100.00%> (-1.90%)` | :arrow_down: | ... and [267 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1865/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
Kielek commented 2 weeks ago

@yiran29, could you please handle comment from @cijothomas? https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1865#pullrequestreview-2100777288

Then the PR can be merged.

yiran29 commented 2 weeks ago

@yiran29, could you please handle comment from @cijothomas? #1865 (review)

Then the PR can be merged.

@Kielek I have updated the CHANGELOG for AWS Instrumentation. Thanks!