search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
421 stars 251 forks source link

[Resources.Azure] Rename `AddAppServiceDetector` to `AddAzureAppServiceDetector` #1874

Closed joegoldman2 closed 1 week ago

joegoldman2 commented 2 weeks ago

I wonder if the method ResourceBuilder.AddAppServiceDetector should be renamed to AddAzureAppServiceDetector to follow the naming convention of other methods which begin with AddAzure (like AddAzureContainerAppsDetector).

namespace OpenTelemetry.Resources;

public static class AzureResourceBuilderExtensions
{
-    public static ResourceBuilder AddAppServiceDetector(this ResourceBuilder builder);
+    public static ResourceBuilder AddAzureAppServiceDetector(this ResourceBuilder builder);
}

This package is still unstable, so renaming is possible.

vishweshbankwar commented 1 week ago

AddAzureAppServiceDetector sounds good to me. @joegoldman2 - Would you like to submit the PR? cc: @rajkumar-rangaraj