open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
421 stars 251 forks source link

[repo] Prepare release Exporter.Geneva-1.9.0-rc.1 #1875

Closed opentelemetrybot closed 1 week ago

opentelemetrybot commented 2 weeks ago

Note: This PR was opened automatically by the prepare release workflow.

Changes

vishweshbankwar commented 2 weeks ago

I do not think that the changelogis true, see

https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/6b604c4b2e030b91958a55da70d4dcc7842f496c/src/OpenTelemetry.Exporter.Geneva/OpenTelemetry.Exporter.Geneva.csproj#L18

Feel free to ignore blocking when you fix/double checking

@Kielek - OtelSdkVersion actually points to OpenTelemetryCoreLatestPrereleaseVersion. See https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/6b604c4b2e030b91958a55da70d4dcc7842f496c/src/OpenTelemetry.Exporter.Geneva/Common.GenevaExporter.props#L3

Will be working on removing this indirect dependency.

vishweshbankwar commented 2 weeks ago

I am going to hold on to this for now: would like to get the change added in Log Exporter to support https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/CHANGELOG.md#190-rc1. Will send a separate PR.

CodeBlanch commented 1 week ago

Just FYI the automation didn't run when this was merged because after #1873 it looks for "[release]" in the PR title not "[repo]". I asked @vishweshbankwar to manually push the tag. Sorry @vishweshbankwar!