Closed AsakerMohd closed 1 week ago
The committers listed above are authorized under a signed CLA.
Changes looks good.
I have a question about test suite. Is there any possibility to include it in pipeline? Maybe executing it in dockerized env? It will be great to ensure that we do not introduce any breaking changes during maintenance.
Package was never released, probably do not need to extend CHANGELOG..
We can look into that.
Also, I'm trying to merge but the build-test workflow seems like it's bugged and doesn't want to start. Any ideas?
It is your first contribution to this repo. It means ci needs approval to be executed.
It is your first contribution to this repo. It means ci needs approval to be executed.
I see. Looks like the build is passing now but it’s still pending your approval although i already have the one approval from you😅
Changes
Updated the Http attributes that were used and replaced them with URL attributes. This is required since some http attributes are no longer used by instrumentation libraries. More info can be found here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/Shared/SemanticConventions.cs#L99-L108
Also applied some small bug fixes to get the sampler to work.
Testing
We have our own test bed for the X-Ray sampler that we use to test the sampling functionality regardless of the language. https://github.com/aws-observability/aws-otel-community/tree/master/centralized-sampling-tests. I followed those testing instructions there and manually instrumented a sample application and the tests are passing which verifies the functionality of the sampler.
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes