search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
454 stars 273 forks source link

[repo] ImplicitUsings - part 1 #1919

Closed Kielek closed 3 months ago

Kielek commented 3 months ago

Changes

Enable implicit usings:

  1. Resources.* packages
  2. Samples.Aws
  3. SemanticConventions.

Part of packages already have enabled this feature. Now we need to disable in shared files IDE0005 to be able to compile. Goal - enable it globally.

For significant contributions please make sure you have completed the following items:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.69%. Comparing base (71655ce) to head (6e82c76). Report is 337 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919/graphs/tree.svg?width=650&height=150&src=pr&token=DG2DEROH83&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #1919 +/- ## ========================================== - Coverage 73.91% 67.69% -6.23% ========================================== Files 267 57 -210 Lines 9615 4290 -5325 ========================================== - Hits 7107 2904 -4203 + Misses 2508 1386 -1122 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests-Exporter.Geneva](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `63.33% <ø> (?)` | | | [unittests-Instrumentation.Runtime](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `97.53% <ø> (?)` | | | [unittests-Sampler.AWS](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.67% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [.../OpenTelemetry.Sampler.AWS/AWSXRayRemoteSampler.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FAWSXRayRemoteSampler.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvQVdTWFJheVJlbW90ZVNhbXBsZXIuY3M=) | `50.72% <ø> (ø)` | | | [...lemetry.Sampler.AWS/AWSXRayRemoteSamplerBuilder.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FAWSXRayRemoteSamplerBuilder.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvQVdTWFJheVJlbW90ZVNhbXBsZXJCdWlsZGVyLmNz) | `82.35% <ø> (ø)` | | | [.../OpenTelemetry.Sampler.AWS/AWSXRaySamplerClient.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FAWSXRaySamplerClient.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvQVdTWFJheVNhbXBsZXJDbGllbnQuY3M=) | `92.95% <ø> (+1.43%)` | :arrow_up: | | [src/OpenTelemetry.Sampler.AWS/Clock.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FClock.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvQ2xvY2suY3M=) | `100.00% <ø> (ø)` | | | [...nTelemetry.Sampler.AWS/GetSamplingRulesResponse.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FGetSamplingRulesResponse.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvR2V0U2FtcGxpbmdSdWxlc1Jlc3BvbnNlLmNz) | `100.00% <ø> (ø)` | | | [...Telemetry.Sampler.AWS/GetSamplingTargetsRequest.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FGetSamplingTargetsRequest.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvR2V0U2FtcGxpbmdUYXJnZXRzUmVxdWVzdC5jcw==) | `100.00% <ø> (ø)` | | | [...elemetry.Sampler.AWS/GetSamplingTargetsResponse.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FGetSamplingTargetsResponse.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvR2V0U2FtcGxpbmdUYXJnZXRzUmVzcG9uc2UuY3M=) | `100.00% <ø> (ø)` | | | [src/OpenTelemetry.Sampler.AWS/Matcher.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FMatcher.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvTWF0Y2hlci5jcw==) | `97.91% <ø> (ø)` | | | [src/OpenTelemetry.Sampler.AWS/RateLimiter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FRateLimiter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvUmF0ZUxpbWl0ZXIuY3M=) | `100.00% <ø> (ø)` | | | [src/OpenTelemetry.Sampler.AWS/RulesCache.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree&filepath=src%2FOpenTelemetry.Sampler.AWS%2FRulesCache.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2FtcGxlci5BV1MvUnVsZXNDYWNoZS5jcw==) | `81.81% <ø> (ø)` | | | ... and [3 more](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | | ... and [231 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1919/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)