open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
421 stars 251 forks source link

[Exporter.Instana] nullable support #1928

Closed zivaninstana closed 3 days ago

zivaninstana commented 3 days ago

Towards https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/894.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 86.39053% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.42%. Comparing base (71655ce) to head (18018eb). Report is 345 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928/graphs/tree.svg?width=650&height=150&src=pr&token=DG2DEROH83&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #1928 +/- ## ========================================== - Coverage 73.91% 71.42% -2.49% ========================================== Files 267 15 -252 Lines 9615 553 -9062 ========================================== - Hits 7107 395 -6712 + Misses 2508 158 -2350 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests-Exporter.Instana](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `71.42% <86.39%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...try.Exporter.Instana/Implementation/InstanaSpan.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FInstanaSpan.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9JbnN0YW5hU3Bhbi5jcw==) | `100.00% <100.00%> (ø)` | | | [...Instana/Implementation/InstanaSpanTransformInfo.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FInstanaSpanTransformInfo.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9JbnN0YW5hU3BhblRyYW5zZm9ybUluZm8uY3M=) | `100.00% <100.00%> (ø)` | | | [...Implementation/Processors/ActivityProcessorBase.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FProcessors%2FActivityProcessorBase.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9Qcm9jZXNzb3JzL0FjdGl2aXR5UHJvY2Vzc29yQmFzZS5jcw==) | `42.85% <100.00%> (-50.00%)` | :arrow_down: | | [...mplementation/Processors/ErrorActivityProcessor.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FProcessors%2FErrorActivityProcessor.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9Qcm9jZXNzb3JzL0Vycm9yQWN0aXZpdHlQcm9jZXNzb3IuY3M=) | `100.00% <100.00%> (ø)` | | | [...plementation/Processors/EventsActivityProcessor.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FProcessors%2FEventsActivityProcessor.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9Qcm9jZXNzb3JzL0V2ZW50c0FjdGl2aXR5UHJvY2Vzc29yLmNz) | `93.75% <100.00%> (ø)` | | | [.../OpenTelemetry.Exporter.Instana/InstanaExporter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FInstanaExporter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbnN0YW5hRXhwb3J0ZXIuY3M=) | `78.37% <92.85%> (ø)` | | | [...Implementation/Processors/TagsActivityProcessor.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FProcessors%2FTagsActivityProcessor.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9Qcm9jZXNzb3JzL1RhZ3NBY3Rpdml0eVByb2Nlc3Nvci5jcw==) | `91.30% <75.00%> (-8.70%)` | :arrow_down: | | [...er.Instana/Implementation/InstanaSpanSerializer.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FInstanaSpanSerializer.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9JbnN0YW5hU3BhblNlcmlhbGl6ZXIuY3M=) | `90.37% <66.66%> (-3.43%)` | :arrow_down: | | [...metry.Exporter.Instana/Implementation/Transport.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FTransport.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9UcmFuc3BvcnQuY3M=) | `0.00% <0.00%> (ø)` | | | [...lementation/Processors/DefaultActivityProcessor.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Instana%2FImplementation%2FProcessors%2FDefaultActivityProcessor.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5zdGFuYS9JbXBsZW1lbnRhdGlvbi9Qcm9jZXNzb3JzL0RlZmF1bHRBY3Rpdml0eVByb2Nlc3Nvci5jcw==) | `59.18% <37.50%> (+1.73%)` | :arrow_up: | ... and [253 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1928/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)