Closed Kielek closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.45%. Comparing base (
71655ce
) to head (72fdd70
). Report is 367 commits behind head on main.
What package is using rc9
? We moved away "rcX" in favor of "rc.X" a long long time ago because it broke sorting on NuGet, possibly also broke resolution. @alanwest do you recall the details?
My suggestion is switch the package in question to use "rc.X" format.
Stack exchange redis and WCF. If we release 1.1.0- beta.1 then manual action from end users will be needed. Nuget will not update utomatically rcX to beta. If we are fine with this, we can just make new releases.
I think switching to beta is the best way to go. I would suggest 1.9.0-beta.1. We also moved off "1.0.0" versions to align on SDK versions IIRC. Example of this being done: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/6f3ae2dd61a3fa8e520b1eb626d6de2873bab9f0/src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md?plain=1#L115-L128
/cc @cijothomas in case he remembers the details with more fidelity.
Update: only StackExchangeRedis instrumentation is affected. Triggered: #1972.
When merged/released this can be closed.
Changes
Fixes possibility to release
-rc9.version
packages. See https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/10038153233/job/27739471486It can be removed in the future, when all packages will be released in the standard way.
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)