search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
454 stars 273 forks source link

[Instrumentation.Owin] Add IConfiguration support #1973

Closed CodeBlanch closed 2 months ago

CodeBlanch commented 2 months ago

Relates to #1960

Changes

Merge requirement checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.79%. Comparing base (71655ce) to head (8e384fe). Report is 368 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973/graphs/tree.svg?width=650&height=150&src=pr&token=DG2DEROH83&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #1973 +/- ## =========================================== + Coverage 73.91% 85.79% +11.88% =========================================== Files 267 8 -259 Lines 9615 169 -9446 =========================================== - Hits 7107 145 -6962 + Misses 2508 24 -2484 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests-Instrumentation.Owin](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `85.79% <80.76%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...umentation.Owin/TracerProviderBuilderExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.Owin%2FTracerProviderBuilderExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLk93aW4vVHJhY2VyUHJvdmlkZXJCdWlsZGVyRXh0ZW5zaW9ucy5jcw==) | `100.00% <100.00%> (+16.66%)` | :arrow_up: | | [...Instrumentation.Owin/OwinInstrumentationOptions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.Owin%2FOwinInstrumentationOptions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLk93aW4vT3dpbkluc3RydW1lbnRhdGlvbk9wdGlvbnMuY3M=) | `84.61% <75.00%> (-15.39%)` | :arrow_down: | | [...n/Implementation/OwinInstrumentationEventSource.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.Owin%2FImplementation%2FOwinInstrumentationEventSource.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLk93aW4vSW1wbGVtZW50YXRpb24vT3dpbkluc3RydW1lbnRhdGlvbkV2ZW50U291cmNlLmNz) | `29.41% <0.00%> (-9.05%)` | :arrow_down: | ... and [266 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1973/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)