search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
473 stars 282 forks source link

[Instrumentation.AspNet] Add IConfiguration support #1976

Closed CodeBlanch closed 3 months ago

CodeBlanch commented 3 months ago

Fixes #1960

Changes

Merge requirement checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.75%. Comparing base (71655ce) to head (2a978d2). Report is 369 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976/graphs/tree.svg?width=650&height=150&src=pr&token=DG2DEROH83&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #1976 +/- ## ========================================== + Coverage 73.91% 76.75% +2.83% ========================================== Files 267 15 -252 Lines 9615 357 -9258 ========================================== - Hits 7107 274 -6833 + Misses 2508 83 -2425 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests-Instrumentation.AspNet](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `76.75% <92.68%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...mentation.AspNet/MeterProviderBuilderExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AspNet%2FMeterProviderBuilderExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFzcE5ldC9NZXRlclByb3ZpZGVyQnVpbGRlckV4dGVuc2lvbnMuY3M=) | `94.11% <100.00%> (-5.89%)` | :arrow_down: | | [...entation.AspNet/TracerProviderBuilderExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AspNet%2FTracerProviderBuilderExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFzcE5ldC9UcmFjZXJQcm92aWRlckJ1aWxkZXJFeHRlbnNpb25zLmNz) | `100.00% <100.00%> (ø)` | | | [...Implementation/AspNetInstrumentationEventSource.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AspNet%2FImplementation%2FAspNetInstrumentationEventSource.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFzcE5ldC9JbXBsZW1lbnRhdGlvbi9Bc3BOZXRJbnN0cnVtZW50YXRpb25FdmVudFNvdXJjZS5jcw==) | `82.35% <66.66%> (+5.42%)` | :arrow_up: | | [...tation.AspNet/AspNetTraceInstrumentationOptions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AspNet%2FAspNetTraceInstrumentationOptions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFzcE5ldC9Bc3BOZXRUcmFjZUluc3RydW1lbnRhdGlvbk9wdGlvbnMuY3M=) | `86.66% <75.00%> (ø)` | | ... and [267 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1976/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)