open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
454 stars 273 forks source link

[Instrumentation.AWS] Add AWS metrics instrumentation #1980

Closed muhammad-othman closed 1 month ago

muhammad-othman commented 2 months ago

Changes

Merge requirement checklist

normj commented 1 month ago

Getting metrics added for the AWS SDK looks really cool in the Aspire Dashboard.

image

vishweshbankwar commented 1 month ago

@muhammad-othman - Could you please take a look at failing tests?

cijothomas commented 1 month ago

@srprash Could you review?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.45%. Comparing base (71655ce) to head (4b0c59f). Report is 379 commits behind head on main.

Files Patch % Lines
...ntation.AWS/Implementation/Metrics/AWSHistogram.cs 71.42% 2 Missing :warning:
....AWS/Implementation/Metrics/AWSMonotonicCounter.cs 71.42% 2 Missing :warning:
...ion.AWS/Implementation/Metrics/AWSUpDownCounter.cs 85.71% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980/graphs/tree.svg?width=650&height=150&src=pr&token=DG2DEROH83&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #1980 +/- ## =========================================== + Coverage 73.91% 90.45% +16.54% =========================================== Files 267 18 -249 Lines 9615 241 -9374 =========================================== - Hits 7107 218 -6889 + Misses 2508 23 -2485 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests-Instrumentation.AWS](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `90.45% <87.50%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...rumentation.AWS/Implementation/Metrics/AWSMeter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AWS%2FImplementation%2FMetrics%2FAWSMeter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFXUy9JbXBsZW1lbnRhdGlvbi9NZXRyaWNzL0FXU01ldGVyLmNz) | `100.00% <100.00%> (ø)` | | | [...ion.AWS/Implementation/Metrics/AWSMeterProvider.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AWS%2FImplementation%2FMetrics%2FAWSMeterProvider.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFXUy9JbXBsZW1lbnRhdGlvbi9NZXRyaWNzL0FXU01ldGVyUHJvdmlkZXIuY3M=) | `100.00% <100.00%> (ø)` | | | [...trumentation.AWS/MeterProviderBuilderExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AWS%2FMeterProviderBuilderExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFXUy9NZXRlclByb3ZpZGVyQnVpbGRlckV4dGVuc2lvbnMuY3M=) | `100.00% <100.00%> (ø)` | | | [...ion.AWS/Implementation/Metrics/AWSUpDownCounter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AWS%2FImplementation%2FMetrics%2FAWSUpDownCounter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFXUy9JbXBsZW1lbnRhdGlvbi9NZXRyaWNzL0FXU1VwRG93bkNvdW50ZXIuY3M=) | `85.71% <85.71%> (ø)` | | | [...ntation.AWS/Implementation/Metrics/AWSHistogram.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AWS%2FImplementation%2FMetrics%2FAWSHistogram.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFXUy9JbXBsZW1lbnRhdGlvbi9NZXRyaWNzL0FXU0hpc3RvZ3JhbS5jcw==) | `71.42% <71.42%> (ø)` | | | [....AWS/Implementation/Metrics/AWSMonotonicCounter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980?src=pr&el=tree&filepath=src%2FOpenTelemetry.Instrumentation.AWS%2FImplementation%2FMetrics%2FAWSMonotonicCounter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuSW5zdHJ1bWVudGF0aW9uLkFXUy9JbXBsZW1lbnRhdGlvbi9NZXRyaWNzL0FXU01vbm90b25pY0NvdW50ZXIuY3M=) | `71.42% <71.42%> (ø)` | | ... and [268 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet-contrib/pull/1980/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)