search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
447 stars 272 forks source link

New Labels Request - `sampler: aws:xray`, `propagator: aws:xray`, and `id-generator: aws:xray` #1991

Open srprash opened 1 month ago

srprash commented 1 month ago

Hello, I'm reaching out on behalf of the AWS X-Ray team. We would like to request the addition of new labels to this repository: sampler: aws:xray, propagator: aws:xray, and id-generator: aws:xray. These labels would be used for PRs and issues pertaining to the X-Ray Sampler, X-Ray Propagator, and X-Ray ID Generator. Ideally, there would be automation that adds these labels to PRs touching X-Ray component code - we would be happy to help with this if some guidance was provided.

Our goal is to have labelling across open-telemetry repositories so that we can find PRs and issues related to the X-Ray components and give faster support to the OTEL community.

Thank you.

cijothomas commented 1 month ago

I tried https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/1994 and it automatically created sampler label

Can you check and let us know what is missing?

CodeBlanch commented 3 weeks ago

@srprash

We have some automation in place. When issues are created we'll add labels based on the component the user selects. For PRs we'll add labels based on files being changed.

For AWS at the moment we have...

When issues are created, based on the component, it looks like the AWS sampler will be tagged as comp:sampler.aws. The propagator and id-generator will both be comp:extensions.aws because they are in the same project.

For issue creation, if you want more granularity, you could create a dedicated template for AWS-related issues. Then you could modify the add-labels script to look for AWS fields from your form and apply tags for what it finds.

For PR tagging. First, do you really need that? I would expect users to open more issues than PRs. Might not be worth the effort. But if you really want it, you can modify that same script where the PR logic is to look at specific AWS paths and apply whatever tags you want.

Happy to create tags for you if you decide to move forward with either plan.