[Asp.Net Core, HttpClient] Clarify Enrich callback sequence

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.

https://opentelemetry.io

Apache License 2.0

454 stars 273 forks source link

[Asp.Net Core, HttpClient] Clarify Enrich callback sequence #2011

Closed vishweshbankwar closed 1 month ago

vishweshbankwar commented 1 month ago

Fixes # Design discussion issue #

Changes

Adding some clarification on sequencing. This is a commonly asked question/issue.

Merge requirement checklist

[ ] CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
[ ] Unit tests added/updated
[ ] Appropriate CHANGELOG.md files updated for non-trivial changes
[ ] Changes in public API reviewed (if applicable)

cijothomas commented 1 month ago

@vishweshbankwar Could you do a similar doc fix for Filter, to call out the Sampling vs Processor vs FilterCallback order?

vishweshbankwar commented 1 month ago

@vishweshbankwar Could you do a similar doc fix for Filter, to call out the Sampling vs Processor vs FilterCallback order?

@cijothomas - We do clarify the sequence of filter versus sampler in the doc. For processor, I think its slightly more complex as that requires some explanation on what could happen to E2E trace if the span is filtered at later stage. I am thinking to clarify it here first: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/docs/trace/extending-the-sdk/MyFilteringProcessor.cs.