open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.

https://opentelemetry.io

Apache License 2.0

474 stars 283 forks source link

Update all projects with `Nullable` #894

Open Kielek opened 1 year ago

Kielek commented 1 year ago

Issue that does not fit into other categories

This issue is to track the effort of updating all projects to support Nullable and remove:

  <Nullable>disable</Nullable>

If possible enable projects one by one with corresponding Tests project to avoid huge PRs.

Ref: https://github.com/open-telemetry/opentelemetry-dotnet/issues/3958

FernandoNunes commented 1 year ago

Hi @Kielek ,

I've started to pick this up. First PR is here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/920

If the required changes are all like the ones of this first PR, once is completed I'll do the rest of the projects / PRs.

Kielek commented 1 year ago

@FernandoNunes, it is the goal, but I would expect more changes related to the code adjustment. See as an example: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/892/files.

Note: the tricky part could be OpenTelemetry.Contrib.Shared project which is compiled-in for multiple projects. What is more it is copied from main/SDK repository. It will be great to enable nullability there and then copy it here.

Kielek commented 5 months ago

@zivaninstana, would you like to contribute to this issue? Exporter.Instana still does not implement this feature.

zivaninstana commented 5 months ago

Yes sure, I will take a look

Kielek commented 1 month ago

Assigning @CodeBlanch as he is working on last part - Geneva exporter.