search

open-telemetry / opentelemetry-dotnet-contrib

This repository contains set of components extending functionality of the OpenTelemetry .NET SDK. Instrumentation libraries, exporters, and other components can find their home here.
https://opentelemetry.io
Apache License 2.0
445 stars 271 forks source link

Flaky test again #910

Open cijothomas opened 1 year ago

cijothomas commented 1 year ago

[xUnit.net 00:00:02.23] OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter [FAIL] [xUnit.net 00:00:02.23] Assert.Equal() Failure [xUnit.net 00:00:02.23] Expected: 1997.0201999999999 [xUnit.net 00:00:02.23] Actual: 0 [xUnit.net 00:00:02.23] Stack Trace: [xUnit.net 00:00:02.23] D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.EventCounters.Tests\EventCountersMetricsTests.cs(74,0): at OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter() Failed OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter [1 s] Error Message: Assert.Equal() Failure Expected: 1997.0201999999999 Actual: 0 Stack Trace: at OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter() in D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.EventCounters.Tests\EventCountersMetricsTests.cs:line 74

cijothomas commented 1 year ago

https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/3958515715

martinjt commented 3 months ago

Looks like this was merged and fixed.

cijothomas commented 3 months ago

Looks like this was merged and fixed.

https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/test/OpenTelemetry.Instrumentation.EventCounters.Tests/EventCountersMetricsTests.cs#L17 The tests are still ignored, not fixed.

martinjt commented 3 months ago

Assigned to the maintainers of the event counters library.