search

open-telemetry / opentelemetry-dotnet-instrumentation

OpenTelemetry .NET Automatic Instrumentation
https://opentelemetry.io
Apache License 2.0
368 stars 91 forks source link

Test coverage: add integration test using ReadyToRun/NGEN #1284

Open pjanotti opened 2 years ago

pjanotti commented 2 years ago

[EDIT: update to clarify that this is about ReadyToRun not AOT]

The code requesting ReJIT of methods targeted for bytecode instrumentation is missing coverage in the following cases:

  1. Instrumenting a method from a module that was NGENed/ReadyToRun;
  2. Instrumenting a method that was inlined;
  3. Instrumenting a method that was inlined and is used by a module that was NGENed;
Kielek commented 2 years ago

SIG meeting notes: Create test similar to StrongNamedAssembly. Our testapp/testlibrary should include method marked as forced inlining. Our bytecode instrumentation should include instrumentation for it (remember about json definition). Then we should cover everything by tests.

Kielek commented 1 year ago

Ref: https://github.com/open-telemetry/opentelemetry-dotnet/issues/3429