search

open-telemetry / opentelemetry-dotnet-instrumentation

OpenTelemetry .NET Automatic Instrumentation
https://opentelemetry.io
Apache License 2.0
364 stars 92 forks source link

Recreate /examples #1388

Closed pellared closed 1 year ago

pellared commented 1 year ago

I think we should change the examples to just contain a client and server app, Dockerfiles, and a docker-compose to run it.

Previously we used it for testing purposes. Right now I think we should make it more .NET devs (users) friendly.

Originally posted by @pellared in https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/1383#pullrequestreview-1135727555

pjanotti commented 1 year ago

Right now there are two instrument.sh scripts on the repo. While refactoring the examples we should look into keeping a single one, see https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/1681#issuecomment-1329908775

pellared commented 1 year ago

TODO: Check https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/issues/1694 when working on this issue.

pellared commented 1 year ago

TODO: Bring back the AspNetCoreMvc example.