search

open-telemetry / opentelemetry-dotnet-instrumentation

OpenTelemetry .NET Automatic Instrumentation
https://opentelemetry.io
Apache License 2.0
364 stars 92 forks source link

Update Examples.AspNetCoreMvc and Examples.Vendor.Distro project with plugin's ConfigureOptions #1691

Closed rajkumar-rangaraj closed 1 year ago

rajkumar-rangaraj commented 1 year ago

Both Examples.AspNetCoreMvc and Examples.Vendor.Distro projects demonstrate the plugin. It would be apt to update these examples to show the usage of ConfigureOptions. We could also update the /docs/plugins.md to show an example link to one of these projects.

Kielek commented 1 year ago

@pellared, as I remember you have a plan to rework most of the examples.

pellared commented 1 year ago

https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/issues/1388 "in progress" I will start working on it tomorrow 😉 I hope to finish it by end of this week.

pellared commented 1 year ago

I decided just to have Initializing in https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/examples/playground/AspNetCoreMvc/OtelSdkPlugin.cs to decrease the maintainability burden. Do you think it is good enough?

Kielek commented 1 year ago

It is good enough. Closing.