search

open-telemetry / opentelemetry-dotnet-instrumentation

OpenTelemetry .NET Automatic Instrumentation
https://opentelemetry.io
Apache License 2.0
369 stars 93 forks source link

Enable Logging for .NET Framework applications #2310

Open Kronos11 opened 1 year ago

Kronos11 commented 1 year ago

Feature Request

Are you requesting automatic instrumentation for a framework or library? Please describe.

Is your feature request related to a problem? Please describe. It's vital we have Logging support in our .NET Framework applications, our application can implement an ILogger solution, but we need them to be picked up by the instrumentation.

Describe the solution you'd like Automatic support for ILogger in .NET Framework

Describe alternatives you've considered Considering writing to a file and having the Collector tail the file to be added.

Additional context Slack conversation: https://cloud-native.slack.com/archives/C01NR1YLSE7/p1678375665847919

rajkumar-rangaraj commented 1 year ago

@Kronos11 I started my work on this issue. Could you please provide a sample app for me to test it.

Kronos11 commented 1 year ago

@Kronos11 I started my work on this issue. Could you please provide a sample app for me to test it.

I will work on a sample app example.

rajkumar-rangaraj commented 1 year ago

@Kronos11 Here are our CI bits from the PR - https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/suites/12008283502/artifacts/630686154. Could you please use this package and test if the logs are exported as expected? Thank you!

Kronos11 commented 1 year ago

@Kronos11 Here are our CI bits from the PR - https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/suites/12008283502/artifacts/630686154. Could you please use this package and test if the logs are exported as expected? Thank you!

I've done a few small tests, but this does seem to be working on a webforms application as well.

Kielek commented 1 year ago

Moving pos-GA after sync wyth @rajkumar-rangaraj .

Kielek commented 10 months ago

Removing milestone per @lachmatt suggestion.

@rajkumar-rangaraj, OTLP is stable now. Can we revisit this?

Kielek commented 9 months ago

SIG notes: Technically it should be possible. Moving back to vNext. Can be picked upped based on the contributor priorities

chamildz commented 3 months ago

@Kielek I wanted to check if you still plan add automatic logging instrumentation support for .NET Framework applications in the near future.