Open Kielek opened 1 year ago
There is new dependency introduced between releases https://github.com/google/re2/compare/2023-03-01...2023-06-01
For now, bumping to 2023-03-01. Keeping track for next upgrades.
Alternative approach - fully drop re2. Regex should be available in all supported version (to be verified).
It will prevent us with introducing more dependencies.
dropping re2 works for Windows and MacOS. Something clearly wrong with Linux distros, none of them passes.
Error: In file included from /home/runner/work/opentelemetry-dotnet-instrumentation/opentelemetry-dotnet-instrumentation/src/OpenTelemetry.AutoInstrumentation.Native/cor_profiler.cpp:10:
09:25:12 [ERR] In file included from /home/runner/work/opentelemetry-dotnet-instrumentation/opentelemetry-dotnet-instrumentation/src/OpenTelemetry.AutoInstrumentation.Native/cor_profiler.cpp:10:
Error: In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/regex:62:
09:25:12 [ERR] In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/regex:62:
Error: In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.h:2998:
09:25:12 [ERR] In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.h:2998:
Error: /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:89:16: error: expected unqualified-id
09:25:12 [ERR] /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:89:16: error: expected unqualified-id
Error: auto& __pre = __m._M_prefix();
09:25:12 [ERR] auto& __pre = __m._M_prefix();
Error: ^
09:25:12 [ERR] ^
Error: /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:93:13: error: expected expression
09:25:12 [ERR] /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:93:13: error: expected expression
Error: __pre.matched = false;
09:25:12 [ERR] __pre.matched = false;
Error: ^
09:25:12 [ERR] ^
Error: /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:94:13: error: expected expression
09:25:12 [ERR] /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:94:13: error: expected expression
Error: __pre.first = __s;
09:25:12 [ERR] __pre.first = __s;
Error: ^
09:25:12 [ERR] ^
Error: /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:95:13: error: expected expression
09:25:12 [ERR] /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:95:13: error: expected expression
Error: __pre.second = __s;
09:25:12 [ERR] __pre.second = __s;
Error: ^
09:25:12 [ERR] ^
Error: /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:102:13: error: expected expression
09:25:12 [ERR] /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:102:13: error: expected expression
Error: __pre.first = __s;
09:25:12 [ERR] __pre.first = __s;
Error: ^
09:25:12 [ERR] ^
Error: /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:103:13: error: expected expression
09:25:12 [ERR] /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:103:13: error: expected expression
Error: __pre.second = __res[0].first;
09:25:12 [ERR] __pre.second = __res[0].first;
Error: ^
09:25:12 [ERR] ^
Error: /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:104:13: error: expected expression
09:25:12 [ERR] /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/regex.tcc:104:13: error: expected expression
Error: __pre.matched = (__pre.first != __pre.second);
09:25:12 [ERR] __pre.matched = (__pre.first != __pre.second);
Error: ^
09:25:12 [ERR]
Update re2 to 2023-06-02 or newer.
It can be separate issue.
_Originally posted by @Kielek in https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/2635#discussion_r1226348255_