Merge the two versions of instrument.sh

[Mpdreamz]

Currently we distribute two versions of instrument.sh

• NuGet instrument.sh: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/nuget/OpenTelemetry.AutoInstrumentation/contentFiles/any/any/instrument.sh

• Redistributable instrument.sh: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/instrument.sh

I believe we could reuse the redistributable instrument.sh with a few minor modifications:

• Fallback to $BASE_PATH for OTEL_DOTNET_AUTO_HOME before falling back to $HOME.
• Change test of OTEL_DOTNET_AUTO_HOME correctness to the presence of OpenTelemetry.AutoInstrumentation.Native.*. (possibly embedded in a $RUNTIME folder).

Happy to submit a PR. Opening an issue early to discuss if this is a good/bad idea 😸

[pjanotti]

Hi @Mpdreamz - I like the idea, IIRC, it was something that came up during some PR review or SIG meeting. At first I don't see any reason to keep them separate.

[pjanotti]

@Mpdreamz are you planning to start working on this? We may want to add it to our next milestone.

[Mpdreamz]

@pjanotti I am :) Just opened https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/3553

I only validated the script still works when using a zip distribution thus far.

[pjanotti]

Nice! Thanks @Mpdreamz