Why is CorrelationContext.entries a List and not a Dictionary?

open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client

https://opentelemetry.io

Apache License 2.0

3.19k stars 755 forks source link

Why is CorrelationContext.entries a List and not a Dictionary? #1028

Closed BalassaMarton closed 4 years ago

BalassaMarton commented 4 years ago

This may be related to #303 - I noticed that the key-value pairs in CorrelationContext and CorrelationContextBuilder are stored in a List<CorrelationContextEntry> instead of a Dictionary<string, CorrelationContextEntry>. Is this a deliberate choice based on use cases of this type?

cijothomas commented 4 years ago

CorrelationContext is being reworked to match spec. (It's also being renamed to BaggageContext). Closing this issue, as we have active PR