search

open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.19k stars 754 forks source link

Concurrent sending in OTLP exporter #1777

Open cijothomas opened 3 years ago

cijothomas commented 3 years ago

Opening to clarify "Concurrent sending" in spec compliance matrix for OTLP exporter. https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md#exporters

The following describes concurrent requests: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#otlpgrpc-concurrent-requests

But the Exporter spec (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#exportbatch) says "Export() will never be called concurrently for the same exporter instance. Export() can be called again only after the current call returns."

If Export() is only called one after another, in the current implementation, there is no question of OTLP exporter needing to support concurrent-requests.

Will mark this spec-compliance section as "-" for .NET for now, and seek more clarification in the spec whether the seemingly contradictory part in spec intentional.

github-actions[bot] commented 1 month ago

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.