open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.23k stars 764 forks source link

Support distinct count feature with OpenTelemetry metrics #4319

Closed dpk83 closed 4 weeks ago

dpk83 commented 1 year ago

Feature Request

Is your feature request related to a problem? Yes.

If so, provide a concise description of the problem. Currently a lot of our services uses distinct count feature to setup their monitoring alerts. These services extensively uses the distinct count feature in backend to configure alerts to they only fire if a value of a specific metric tag is above certain threshold. Or to configure different severity based on the unique values of the specific dimension. To make the scenario more clear, here is a concrete example.

To avoid this situation and to assess the importance of an issue, services uses distinct count to determine the number of users impacted. The combination of unique number of users impacted and the reliability drop provides the right set of information to setup alerts at right severity.

With OpenTelemetry due to client side aggregation and the reason that such tags like userIds, or orgIds are high cardinality, the distinct count features is not supported.

Describe the solution you'd like:

Describe alternatives you've considered.

No alternatives other than staying on the existing non open telemetry metrics solution which provides the feature.

Additional Context

Add any other context about the feature request here.

cijothomas commented 1 year ago

With OpenTelemetry due to client side aggregation and the reason that such tags like userIds, or orgIds are high cardinality, the distinct count features is not supported.

This does not like something specific to OTel .NET but for all languages. The "distinct count" is not an aggregation part of the OTel sdk specification. I'd suggest to have this opened in specification repo to see if spec can add support for such thing, or open up pluggable custom aggregators.

github-actions[bot] commented 1 month ago

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

github-actions[bot] commented 4 weeks ago

Closed as inactive. Feel free to reopen if this issue is still a concern.