search

open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.24k stars 764 forks source link

Stabilize OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES #5462

Open vishweshbankwar opened 8 months ago

cjablonski76 commented 3 months ago

@vishweshbankwar any movement on this topic? The company I work for would benefit from this, as would many others I presume.

It's difficult to convince a company to start depending on the attributes logged with OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES enabled if we know that it is planned to go away without a moments notice.

vishweshbankwar commented 3 months ago

@cjablonski76 - its planned for 1.10.0 milestone(Nov).

CodeBlanch commented 3 months ago

I just opened a new spec PR to try and get the ball moving: https://github.com/open-telemetry/semantic-conventions/pull/1339

I had another one open but it just went into a void 😢

cijothomas commented 2 months ago

Removing from 1.10.0 milestone, as it is not possible to get blessing from Spec/Conventions in this time. There will be changes to OTel Events based on https://github.com/open-telemetry/oteps/pull/265, and it is an open question whether ILogger Logs with EventName should be an Event or not, and more importantly - it is an open question if LogRecord adds a top-level field for EventName vs putting it as attributes. Until these questions are resolved, we cannot make this stabilized.

(The alternate of stabilizing a .NET specific way by storing this in attribute like "dotnet.ilogger.event.name" is highly undesired, given OTel's desire to make Events a first class thing.)

Unfortunately, there is no firm ETA for this item now, as we rely on spec progress which (as of today), has no firm ETA either.