search

open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.18k stars 753 forks source link

[Exporter.Console, Exporter.InMemory] Nullable #5765

Closed Kielek closed 2 months ago

Kielek commented 2 months ago

Towards #3958

Changes

[Exporter.Console, Exporter.InMemory] Nullable

Merge requirement checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.20%. Comparing base (6250307) to head (cc4ce14). Report is 284 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765/graphs/tree.svg?width=650&height=150&src=pr&token=vscyfvPfy5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5765 +/- ## ========================================== + Coverage 83.38% 86.20% +2.81% ========================================== Files 297 256 -41 Lines 12531 11102 -1429 ========================================== - Hits 10449 9570 -879 + Misses 2082 1532 -550 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `?` | | | [unittests-Project-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.19% <0.00%> (?)` | | | [unittests-Project-Stable](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.19% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...xporter.Console/ConsoleExporterHelperExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Console%2FConsoleExporterHelperExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuQ29uc29sZS9Db25zb2xlRXhwb3J0ZXJIZWxwZXJFeHRlbnNpb25zLmNz) | `0.00% <ø> (ø)` | | | [...porter.Console/ConsoleExporterLoggingExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Console%2FConsoleExporterLoggingExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuQ29uc29sZS9Db25zb2xlRXhwb3J0ZXJMb2dnaW5nRXh0ZW5zaW9ucy5jcw==) | `0.00% <ø> (ø)` | | | [...porter.Console/ConsoleExporterMetricsExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Console%2FConsoleExporterMetricsExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuQ29uc29sZS9Db25zb2xlRXhwb3J0ZXJNZXRyaWNzRXh0ZW5zaW9ucy5jcw==) | `0.00% <ø> (ø)` | | | [...penTelemetry.Exporter.InMemory/InMemoryExporter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.InMemory%2FInMemoryExporter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5NZW1vcnkvSW5NZW1vcnlFeHBvcnRlci5jcw==) | `81.81% <ø> (ø)` | | | [...rter.InMemory/InMemoryExporterMetricsExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.InMemory%2FInMemoryExporterMetricsExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuSW5NZW1vcnkvSW5NZW1vcnlFeHBvcnRlck1ldHJpY3NFeHRlbnNpb25zLmNz) | `97.72% <ø> (ø)` | | | [...emetry.Exporter.Console/ConsoleActivityExporter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Console%2FConsoleActivityExporter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuQ29uc29sZS9Db25zb2xlQWN0aXZpdHlFeHBvcnRlci5jcw==) | `48.33% <0.00%> (+0.05%)` | :arrow_up: | | [...elemetry.Exporter.Console/ConsoleMetricExporter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Console%2FConsoleMetricExporter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuQ29uc29sZS9Db25zb2xlTWV0cmljRXhwb3J0ZXIuY3M=) | `0.00% <0.00%> (ø)` | | | [...xporter.Console/Implementation/ConsoleTagWriter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Console%2FImplementation%2FConsoleTagWriter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuQ29uc29sZS9JbXBsZW1lbnRhdGlvbi9Db25zb2xlVGFnV3JpdGVyLmNz) | `11.11% <0.00%> (ø)` | | | [...metry.Exporter.Console/ConsoleLogRecordExporter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Console%2FConsoleLogRecordExporter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuQ29uc29sZS9Db25zb2xlTG9nUmVjb3JkRXhwb3J0ZXIuY3M=) | `0.00% <0.00%> (ø)` | | ... and [202 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5765/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)