search

open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.23k stars 765 forks source link

[Exporter.Zipkin] Nullable #5792

Closed ysolomchenko closed 2 months ago

ysolomchenko commented 2 months ago

Towards https://github.com/open-telemetry/opentelemetry-dotnet/issues/3958

Changes

Merge requirement checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.34%. Comparing base (6250307) to head (49b9c87). Report is 308 commits behind head on main.

Files with missing lines Patch % Lines
...plementation/ZipkinActivityConversionExtensions.cs 91.30% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792/graphs/tree.svg?width=650&height=150&src=pr&token=vscyfvPfy5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5792 +/- ## ========================================== + Coverage 83.38% 86.34% +2.95% ========================================== Files 297 257 -40 Lines 12531 11152 -1379 ========================================== - Hits 10449 9629 -820 + Misses 2082 1523 -559 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `?` | | | [unittests-Project-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.23% <96.42%> (?)` | | | [unittests-Project-Stable](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.17% <96.42%> (?)` | | | [unittests-Solution](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.33% <96.42%> (?)` | | | [unittests-UnstableCoreLibraries-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `85.76% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...y.Exporter.Zipkin/Implementation/ZipkinEndpoint.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Zipkin%2FImplementation%2FZipkinEndpoint.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuWmlwa2luL0ltcGxlbWVudGF0aW9uL1ppcGtpbkVuZHBvaW50LmNz) | `80.48% <100.00%> (ø)` | | | [...metry.Exporter.Zipkin/Implementation/ZipkinSpan.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Zipkin%2FImplementation%2FZipkinSpan.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuWmlwa2luL0ltcGxlbWVudGF0aW9uL1ppcGtpblNwYW4uY3M=) | `96.15% <100.00%> (+1.15%)` | :arrow_up: | | [...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Zipkin%2FZipkinExporter.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuWmlwa2luL1ppcGtpbkV4cG9ydGVyLmNz) | `88.42% <100.00%> (+2.98%)` | :arrow_up: | | [....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Zipkin%2FZipkinExporterHelperExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuWmlwa2luL1ppcGtpbkV4cG9ydGVySGVscGVyRXh0ZW5zaW9ucy5jcw==) | `98.24% <100.00%> (+0.06%)` | :arrow_up: | | [...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Zipkin%2FZipkinExporterOptions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuWmlwa2luL1ppcGtpbkV4cG9ydGVyT3B0aW9ucy5jcw==) | `100.00% <100.00%> (ø)` | | | [...plementation/ZipkinActivityConversionExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792?src=pr&el=tree&filepath=src%2FOpenTelemetry.Exporter.Zipkin%2FImplementation%2FZipkinActivityConversionExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuRXhwb3J0ZXIuWmlwa2luL0ltcGxlbWVudGF0aW9uL1ppcGtpbkFjdGl2aXR5Q29udmVyc2lvbkV4dGVuc2lvbnMuY3M=) | `95.79% <91.30%> (-0.79%)` | :arrow_down: | ... and [215 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5792/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
github-actions[bot] commented 2 months ago

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.