open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.23k stars 765 forks source link

[Shims, W3C.Tests] Nullable #5797

Closed ysolomchenko closed 2 months ago

ysolomchenko commented 2 months ago

Towards https://github.com/open-telemetry/opentelemetry-dotnet/issues/3958

Changes

Merge requirement checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.22%. Comparing base (6250307) to head (c230635). Report is 316 commits behind head on main.

Files with missing lines Patch % Lines
src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs 69.23% 4 Missing :warning:
...OpenTelemetry.Shims.OpenTracing/SpanBuilderShim.cs 94.11% 1 Missing :warning:
src/OpenTelemetry.Shims.OpenTracing/TracerShim.cs 50.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797/graphs/tree.svg?width=650&height=150&src=pr&token=vscyfvPfy5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5797 +/- ## ========================================== + Coverage 83.38% 86.22% +2.84% ========================================== Files 297 257 -40 Lines 12531 11169 -1362 ========================================== - Hits 10449 9631 -818 + Misses 2082 1538 -544 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `?` | | | [unittests-Project-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `85.95% <82.35%> (?)` | | | [unittests-Project-Stable](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.22% <82.35%> (?)` | | | [unittests-UnstableCoreLibraries-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `85.71% <82.35%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...penTelemetry.Shims.OpenTracing/ScopeManagerShim.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797?src=pr&el=tree&filepath=src%2FOpenTelemetry.Shims.OpenTracing%2FScopeManagerShim.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2hpbXMuT3BlblRyYWNpbmcvU2NvcGVNYW5hZ2VyU2hpbS5jcw==) | `96.77% <100.00%> (ø)` | | | [...OpenTelemetry.Shims.OpenTracing/SpanBuilderShim.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797?src=pr&el=tree&filepath=src%2FOpenTelemetry.Shims.OpenTracing%2FSpanBuilderShim.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2hpbXMuT3BlblRyYWNpbmcvU3BhbkJ1aWxkZXJTaGltLmNz) | `90.58% <94.11%> (-0.11%)` | :arrow_down: | | [src/OpenTelemetry.Shims.OpenTracing/TracerShim.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797?src=pr&el=tree&filepath=src%2FOpenTelemetry.Shims.OpenTracing%2FTracerShim.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2hpbXMuT3BlblRyYWNpbmcvVHJhY2VyU2hpbS5jcw==) | `91.66% <50.00%> (ø)` | | | [src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797?src=pr&el=tree&filepath=src%2FOpenTelemetry.Shims.OpenTracing%2FSpanShim.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuU2hpbXMuT3BlblRyYWNpbmcvU3BhblNoaW0uY3M=) | `80.20% <69.23%> (-1.32%)` | :arrow_down: | ... and [219 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5797/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
github-actions[bot] commented 2 months ago

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.