open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.23k stars 765 forks source link

[Api] Nullable #5801

Closed ysolomchenko closed 1 month ago

ysolomchenko commented 2 months ago

Towards https://github.com/open-telemetry/opentelemetry-dotnet/issues/3958

Changes

OpenTelemety.Api mark as nullable

Merge requirement checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.33%. Comparing base (6250307) to head (cae599f). Report is 329 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801/graphs/tree.svg?width=650&height=150&src=pr&token=vscyfvPfy5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5801 +/- ## ========================================== + Coverage 83.38% 86.33% +2.95% ========================================== Files 297 257 -40 Lines 12531 11193 -1338 ========================================== - Hits 10449 9664 -785 + Misses 2082 1529 -553 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `?` | | | [unittests-Project-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.14% <ø> (?)` | | | [unittests-Project-Stable](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.20% <ø> (?)` | | | [unittests-Solution](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.25% <ø> (?)` | | | [unittests-UnstableCoreLibraries-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `85.75% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [src/OpenTelemetry.Api/ActivityContextExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FActivityContextExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0FjdGl2aXR5Q29udGV4dEV4dGVuc2lvbnMuY3M=) | `100.00% <ø> (ø)` | | | [src/OpenTelemetry.Api/Baggage.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FBaggage.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0JhZ2dhZ2UuY3M=) | `100.00% <ø> (ø)` | | | [src/OpenTelemetry.Api/BaseProvider.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FBaseProvider.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0Jhc2VQcm92aWRlci5jcw==) | `100.00% <ø> (ø)` | | | [...emetry.Api/Context/AsyncLocalRuntimeContextSlot.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FAsyncLocalRuntimeContextSlot.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvQXN5bmNMb2NhbFJ1bnRpbWVDb250ZXh0U2xvdC5jcw==) | `100.00% <ø> (+25.00%)` | :arrow_up: | | [...nTelemetry.Api/Context/Propagation/B3Propagator.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FPropagation%2FB3Propagator.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUHJvcGFnYXRpb24vQjNQcm9wYWdhdG9yLmNz) | `86.02% <ø> (+0.15%)` | :arrow_up: | | [...metry.Api/Context/Propagation/BaggagePropagator.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FPropagation%2FBaggagePropagator.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUHJvcGFnYXRpb24vQmFnZ2FnZVByb3BhZ2F0b3IuY3M=) | `85.00% <ø> (-0.49%)` | :arrow_down: | | [.../Context/Propagation/CompositeTextMapPropagator.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FPropagation%2FCompositeTextMapPropagator.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUHJvcGFnYXRpb24vQ29tcG9zaXRlVGV4dE1hcFByb3BhZ2F0b3IuY3M=) | `100.00% <ø> (+16.66%)` | :arrow_up: | | [...y.Api/Context/Propagation/NoopTextMapPropagator.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FPropagation%2FNoopTextMapPropagator.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUHJvcGFnYXRpb24vTm9vcFRleHRNYXBQcm9wYWdhdG9yLmNz) | `33.33% <ø> (+33.33%)` | :arrow_up: | | [...etry.Api/Context/Propagation/PropagationContext.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FPropagation%2FPropagationContext.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUHJvcGFnYXRpb24vUHJvcGFnYXRpb25Db250ZXh0LmNz) | `64.28% <ø> (ø)` | | | [...enTelemetry.Api/Context/Propagation/Propagators.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FPropagation%2FPropagators.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUHJvcGFnYXRpb24vUHJvcGFnYXRvcnMuY3M=) | `100.00% <ø> (ø)` | | | ... and [25 more](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | | ... and [228 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5801/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
github-actions[bot] commented 2 months ago

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.