search

open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.18k stars 753 forks source link

[api] Context nullable annotations #5850

Closed CodeBlanch closed 3 days ago

CodeBlanch commented 1 week ago

Relates to #5801

Changes

Details

This was split off from #5801 so it could be reviewed/discussed independently.

Merge requirement checklist

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Project coverage is 86.30%. Comparing base (6250307) to head (2023505). Report is 328 commits behind head on main.

Files with missing lines Patch % Lines
...elemetry.Api/Context/RemotingRuntimeContextSlot.cs 0.00% 8 Missing :warning:
...metry.Api/Context/ThreadLocalRuntimeContextSlot.cs 0.00% 4 Missing :warning:
src/OpenTelemetry.Api/Context/RuntimeContext.cs 40.00% 3 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850/graphs/tree.svg?width=650&height=150&src=pr&token=vscyfvPfy5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5850 +/- ## ========================================== + Coverage 83.38% 86.30% +2.91% ========================================== Files 297 257 -40 Lines 12531 11193 -1338 ========================================== - Hits 10449 9660 -789 + Misses 2082 1533 -549 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `?` | | | [unittests-Project-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.21% <31.81%> (?)` | | | [unittests-Project-Stable](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.27% <31.81%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...emetry.Api/Context/AsyncLocalRuntimeContextSlot.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FAsyncLocalRuntimeContextSlot.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvQXN5bmNMb2NhbFJ1bnRpbWVDb250ZXh0U2xvdC5jcw==) | `100.00% <100.00%> (+25.00%)` | :arrow_up: | | [...rc/OpenTelemetry.Api/Context/RuntimeContextSlot.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FRuntimeContextSlot.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUnVudGltZUNvbnRleHRTbG90LmNz) | `55.55% <100.00%> (+5.55%)` | :arrow_up: | | [src/OpenTelemetry.Api/Context/RuntimeContext.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FRuntimeContext.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUnVudGltZUNvbnRleHQuY3M=) | `47.72% <40.00%> (-0.10%)` | :arrow_down: | | [...metry.Api/Context/ThreadLocalRuntimeContextSlot.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FThreadLocalRuntimeContextSlot.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvVGhyZWFkTG9jYWxSdW50aW1lQ29udGV4dFNsb3QuY3M=) | `0.00% <0.00%> (ø)` | | | [...elemetry.Api/Context/RemotingRuntimeContextSlot.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FContext%2FRemotingRuntimeContextSlot.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL0NvbnRleHQvUmVtb3RpbmdSdW50aW1lQ29udGV4dFNsb3QuY3M=) | `0.00% <0.00%> (ø)` | | ... and [227 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5850/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)