open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.23k stars 765 forks source link

[repo] Update stale.yml - reduce days before stale to 600 #5857

Closed TimothyMothra closed 1 month ago

TimothyMothra commented 1 month ago

Follow up to https://github.com/open-telemetry/opentelemetry-dotnet/issues/5776

This PR moves the days-before-issue-stale from 900 to 600. The ultimate goal is to get this down to 300 days.

Counts of issues

Screenshot of affected issues

Click here to expand ![image](https://github.com/user-attachments/assets/afa77227-2236-4212-9b24-dc036ee256a9) ![image](https://github.com/user-attachments/assets/aa32107e-4857-4dd7-8642-f366267ddd63) ![image](https://github.com/user-attachments/assets/342b69ff-ce2e-429e-90f7-1d49c190cea8)
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.39%. Comparing base (6250307) to head (ddd593a). Report is 324 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857/graphs/tree.svg?width=650&height=150&src=pr&token=vscyfvPfy5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5857 +/- ## ========================================== + Coverage 83.38% 86.39% +3.00% ========================================== Files 297 257 -40 Lines 12531 11194 -1337 ========================================== - Hits 10449 9671 -778 + Misses 2082 1523 -559 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `?` | | | [unittests-Project-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.29% <ø> (?)` | | | [unittests-Project-Stable](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.24% <ø> (?)` | | | [unittests-Solution](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.37% <ø> (?)` | | | [unittests-UnstableCoreLibraries-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `85.75% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. [see 224 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5857/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
reyang commented 1 month ago

Could you paste the list of the issues that will be closed here? Having a snapshot would be helpful.

TimothyMothra commented 1 month ago

Could you paste the list of the issues that will be closed here? Having a snapshot would be helpful.

Here's that link: https://github.com/open-telemetry/opentelemetry-dotnet/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-asc+updated%3A%3C%3D2023-02-01+ I also updated my description above.

Just to be clear, nothing will be immediately closed when this PR merges. If this merged today, when the stale automation runs tonight it will tag issues as stale. Those issues would have 7 days for our team to review before they get closed.

reyang commented 1 month ago

Not sure if the link would work in the future. I think having a snapshot list would be helpful.

TimothyMothra commented 1 month ago

Not sure if the link would work in the future. I think having a snapshot list would be helpful.

Can you help me understand what's the goal you're trying to accomplish? Is this to create a historical record of the issues that would be affected?

I added a screenshot of the affected issues but I want to make sure I'm addressing your concern.

Creating a written list wouldn't be a good use of my time, and worse if I included a list of the hyperlinks that reference would count as activity and would reset the clock.

reyang commented 1 month ago

Not sure if the link would work in the future. I think having a snapshot list would be helpful.

Can you help me understand what's the goal you're trying to accomplish? Is this to create a historical record of the issues that would be affected?

I asked this specifically because there are tracking issues that intend to stay open, I think we should review the list instead of blindly close them all. For example, #2622.

TimothyMothra commented 1 month ago

I asked this specifically because there are tracking issues that intend to stay open, I think we should review the list instead of blindly close them all.

Ahh makes sense. When an issue gets marked stale, we're really depending on the original person to comment that this is still needed. Worst case if something gets closed, we would gladly reopen it. :)

I think you missed the first PR when we started this effort. We started at 1200 days old, so we could individually review a small group of issues at a time without overwhelming maintainers. We absolutely do not want to hastily close issues!

We've also discussed excluding certain labels but are currently using the "Future" milestone to exclude issues from Stale.

rajkumar-rangaraj commented 1 month ago

@TimothyMothra If you could reopen https://github.com/open-telemetry/opentelemetry-dotnet/issues/5776 and explain the process we follow for issues marked as stale, it would be helpful. Once this exercise is complete, we can work on formalizing the process and documenting it in the repository

rajkumar-rangaraj commented 1 month ago

Not sure if the link would work in the future. I think having a snapshot list would be helpful.

I like this idea. It will also help us track how many issues were closed as stale and how many we reviewed and moved forward.