search

open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.18k stars 752 forks source link

[bug] Mark instrumentation scope attributes as identifying #5859

Open cijothomas opened 1 hour ago

cijothomas commented 1 hour ago

Package

OpenTelemetry

Package Version

Package Name Version
OpenTelemetry.Api 1.8.0
OpenTelemetry 1.8.0
TBD TBD

Runtime Version

N/A

Description

Recently spec made scope tags as identifying. Only Metrics are affected today in this repo, but when we add Scope tags for Activitysource for .NET9, this should be considered. https://github.com/open-telemetry/opentelemetry-specification/pull/4161#issuecomment-2261242491

Steps to Reproduce

https://github.com/open-telemetry/opentelemetry-specification/pull/4161#issuecomment-2261242491 shows the unittest

Expected Result

make scope properties identifying

Actual Result

https://github.com/open-telemetry/opentelemetry-specification/pull/4161#issuecomment-2261242491

Additional Context

No response

cijothomas commented 1 hour ago

@rajkumar-rangaraj https://github.com/open-telemetry/opentelemetry-dotnet/issues/5701 - Unsure if there is anything particular to be done for traces here. Most likely none.