search

open-telemetry / opentelemetry-erlang-api

Erlang/Elixir OpenTelemetry API
Apache License 2.0
60 stars 13 forks source link

Support arrays for attribute values #37

Closed tsloughter closed 3 years ago

julien-leclercq commented 4 years ago

This is actually kind of a bug, in the current state of the repo, OpenTelemetry.Tracer.with_span cannot be used with start_opts because the type of start_opts is a map and they cannot be used in macros unless they are escaped, but then the underlying code would not work either.

tsloughter commented 4 years ago

@julien-leclercq that would be a separate issue you are describing. This is about attributes on a span.

I've not heard of this maps can not be used in macros? Can you open a new issue.

tolbrino commented 4 years ago

is a map and they cannot be used in macros unless they are escaped, but then the underlying code would not work either.

Could you point to a reference which describes this behaviour? Its actually news to me, therefore I'm asking.

julien-leclercq commented 4 years ago

nevermind I did a mistake while defining my own wrapper, forget what I said. Sorry for the message.