Fix issues-48 - Githubissues

open-telemetry / opentelemetry-erlang-api

Erlang/Elixir OpenTelemetry API

Apache License 2.0

60 stars 13 forks source link

Fix issues-48 #56

Closed yatender-oktalk closed 4 years ago

yatender-oktalk commented 4 years ago

OpenTelemetry removing /" and replacing this with " as it creates confusion.
Updated the example doc for the new API updates.

Modified OpenTelemetry.Span Following changes were done.

Changes related to documentation example add_event
Updated add_event/1 to add_event/2 to accept event_name and event_attributes.

tsloughter commented 4 years ago

Thanks! Do the docs generate and render correctly without the quoted strings? I could have swore I would have added those for a reason...

yatender-oktalk commented 4 years ago

Yeah it does correctly, no need to put \" :)

On Tue, 2 Jun, 2020, 9:24 pm Tristan Sloughter, notifications@github.com wrote:

Thanks! Do the docs generate and render correctly without the quoted strings? I could have swore I would have added those for a reason...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/open-telemetry/opentelemetry-erlang-api/pull/56#issuecomment-637642413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPVH53Z6VJT7KOC62ZLDO3RUUOBZANCNFSM4NQP22VA .

tsloughter commented 4 years ago

Ok, thanks!