search

open-telemetry / opentelemetry-erlang-api

Erlang/Elixir OpenTelemetry API
Apache License 2.0
60 stars 13 forks source link

mix support for rebar3 git_subdir resource #61

Closed tsloughter closed 4 years ago

tsloughter commented 4 years ago

Rebar3 3.14.0 will have support for a git_subdir resource that allows the user to specify the directory in a git repo where an application is found. This is what we should switch opentelemetry-erlang-api/opentelemetry-erlang repos to use and become a single opentelemetry-erlang repository. But we can't do that until mix supports reading in this type of resource from rebar.config.

We should also do this for exporters I think. My thinking is that opentelemetry-beam org will be used to start exporters, experiments and examples but the exporters will then be merged into a single repo opentelemetry-erlang-contrib or something like that. This will make it easier to keep exporters working with the latest Otel releases.

I'm opening this here in hopes someone is interested in adding the mix support :)

DianaOlympos commented 4 years ago

Maybe open the issue in the elixir repo directly ? So that it has more visibility and the Core team may comment on what is needed ?

tsloughter commented 4 years ago

Their issue template says not to open issues for features.

DianaOlympos commented 4 years ago

Fair. I suppose it is a mailing list thing then. Or an elixirforum

tsloughter commented 4 years ago

Are you on the list? :)

Someone here must be and also be interested in sending this out to the list to make it visible?

DianaOlympos commented 4 years ago

I think the list is open. I am probably as i offered features before. Only problem is that i would have no time to take care of it right now

hauleth commented 4 years ago

https://groups.google.com/forum/#!topic/elixir-lang-core/rrqHJmSXlOQ proposed.

tsloughter commented 4 years ago

@hauleth thanks but it needs to be clear this is about support for rebar3 subdirs. Mix reads in rebar.config and parses it. Best to just link to this issue I think.

tsloughter commented 4 years ago

Completed and repos have been merged: https://github.com/open-telemetry/opentelemetry-erlang