search

open-telemetry / opentelemetry-erlang-api

Erlang/Elixir OpenTelemetry API
Apache License 2.0
60 stars 13 forks source link

Remove CircleCI #81

Closed davydog187 closed 3 years ago

davydog187 commented 3 years ago

Github actions appears to be the CI system now

linux-foundation-easycla[bot] commented 3 years ago

CLA Check
The committers are authorized under a signed CLA.

davydog187 commented 3 years ago

CircleCI and github actions don't have 100% parity. Its unclear to me what needs to be moved over, if anything

tsloughter commented 3 years ago

Thanks! This is all that is needed except it is blocked because it, of course, breaks the circleci build and I need to figure out how to tell github to not care about it anymore...

SergeyKanzhelev commented 3 years ago

Thanks! This is all that is needed except it is blocked because it, of course, breaks the circleci build and I need to figure out how to tell github to not care about it anymore...

It looks like it was already done. It is not a required check on this branch in settings. Let me know if some help is needed here

davydog187 commented 3 years ago

@tsloughter you can do that via Settings -> Branches -> (Edit) Master -> Uncheck circle ci under Require status checks to pass before merging

SergeyKanzhelev commented 3 years ago

@tsloughter you can do that via Settings -> Branches -> (Edit) Master -> Uncheck circle ci under Require status checks to pass before merging

it is already unchecked. You can see it in this PR essage - there is no "Required" label:

image

tsloughter commented 3 years ago

Yup, my bad it was only blocked since I hadn't approved it yet :), thanks @SergeyKanzhelev