Update Obans semantic conventions

open-telemetry / opentelemetry-erlang-contrib

OpenTelemetry instrumentation for Erlang & Elixir

https://opentelemetry.io

Apache License 2.0

164 stars 115 forks source link

Update Obans semantic conventions #400

Open joshk opened 3 weeks ago

joshk commented 3 weeks ago

This also required the removal of messaging_destination_kind() as I couldn't find an equivalent in opentelemetry_semantic_conventions ~> 1.27

linux-foundation-easycla[bot] commented 3 weeks ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: joshk / name: Josh Kalderimis (6acd4bb3923f286963b1ae8d4a672f9933df717c, e654f0ed8b8b6aa683514cd2db70f4e08bc136cc, 2ada0a1a7043706683701dfa1bda7560699be25b, d25c174e27c9fb49a38173a7cc7e74f5e09c5293)

joshk commented 3 weeks ago

@tsloughter, sorry to ask. Would it be possible to get a review on this PR?

joshk commented 2 weeks ago

Hi @bryannaegele , sorry to ask, would it be possible to get approval for the CI to run for this PR?

bryannaegele commented 2 weeks ago

Sure. Approving to run. Just took a brief glance (not a review) and there look to be a number of issues still to address with the spec. Please take a pass through the spec to cover your bases.

https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/

joshk commented 1 week ago

Hi @bryannaegele , I've updated the code based on the spec, and adjusted the test suite to match.

Could you please approve the CI run once more?

joshk commented 1 week ago

@bryannaegele sorry, is there anything i can do to help this move forward?

bryannaegele commented 1 week ago

Hey @joshk, it can take a couple of weeks for me to have time to review a PR. From another quick glance, it looks like there's still a fair amount that doesn't match the spec. A simple one is the span names. There are also updates since the original implementation around batching, so create and process may be more appropriate for operations.

If you can read through the spec top to bottom and go through the requirements one at a time, that can help move things forward.

joshk commented 1 week ago

Hey @bryannaegele , I'm sorry to ping you, and I appreciate the guidance.

Hmmm, I went through the spec and thought I had everything up to date. I'll go through everything again. Could you point me to an example of something I haven't implemented correctly? (It would help me see where I'm not reading the spec, if that makes sense)

I'm very happy to contribute further, once I'm getting this right :)

bryannaegele commented 1 week ago

I pointed out span names as one example. My recommendation is open the spec page and view it as a check list going from top to bottom, applying anything that's relevant to how oban works