search

open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories
https://opentelemetry.io
Apache License 2.0
32 stars 35 forks source link

multimod: ignore `excluded-modules` when `-a` flag is enabled #442

Closed codeboten closed 10 months ago

codeboten commented 10 months ago

This allows users of the sync command to sync all modules in a monorepo, including those listed in the excluded-modules. This is useful for repositories where some modules may not yet be ready for releasing (therefore listed under excluded-modules) but their dependencies still need to be managed via multimod.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (49952c1) 63.51% compared to head (63a96fe) 63.65%.

Files Patch % Lines
multimod/internal/sync/sync.go 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #442 +/- ## ========================================== + Coverage 63.51% 63.65% +0.14% ========================================== Files 39 39 Lines 2250 2259 +9 ========================================== + Hits 1429 1438 +9 Misses 677 677 Partials 144 144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeboten commented 10 months ago

Do we need this flag? Is there any reason why it shouldn't we simply change the behavior without introducing the flag?

It's a good question, I didn't want to assume that all users would benefit from this change, but thinking back on it, maybe it is desirable for all users to update sync deps even for excluded modules. I could go either ways with this.

codeboten commented 10 months ago

@pellared after re-thinking this, I changed the behaviour for anyone that uses the -a flag