search

open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories
https://opentelemetry.io
Apache License 2.0
32 stars 35 forks source link

dbotconf: Fix Windows produces backslashes instead of slashes #448

Closed scorpionknifes closed 10 months ago

scorpionknifes commented 10 months ago

Fixes #264

@pellared

multimod tag is also not working correctly because of backslashes on Windows.

I guess crosslink will have the same issue.

Shall look into multimod and crosslink

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8081a8c) 63.68% compared to head (6a397d5) 63.72%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #448 +/- ## ========================================== + Coverage 63.68% 63.72% +0.03% ========================================== Files 39 39 Lines 2261 2263 +2 ========================================== + Hits 1440 1442 +2 Misses 677 677 Partials 144 144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pellared commented 10 months ago

I created https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/450

pellared commented 10 months ago

Shall look into multimod and crosslink.

Can you quickly test it and create issues if these tools have the same bug?

pellared commented 10 months ago

Thanks a lot for your PR 👍 Awaiting second review.