Run golangci-lint on Windows

open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories

https://opentelemetry.io

Apache License 2.0

32 stars 35 forks source link

Run golangci-lint on Windows #451

Closed pellared closed 9 months ago

pellared commented 10 months ago

internal\syncerror\known_sync_error_windows.go:27:9: comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
        return err == windows.ERROR_INVALID_HANDLE

Interesting, didn't know golangci-lint doesn't check go files for Windows when ran on unix systems (ci).

_Originally posted by @scorpionknifes in https://github.com/open-telemetry/opentelemetry-go-build-tools/pull/448#discussion_r1417139422_

pellared commented 10 months ago

Probably it can be run with GOOS=windows on Linux.

pellared commented 9 months ago

Fixed by https://github.com/open-telemetry/opentelemetry-go-build-tools/pull/466