open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories
https://opentelemetry.io
Apache License 2.0
32 stars 35 forks source link

[chloggen] Update permissions of the generated files #457

Closed pantuza closed 10 months ago

pantuza commented 10 months ago

Contributions

When you use chloggen new --config template.yaml --filename contribution.yaml the generated file has 0755 permission. Thus, it generates yaml files with Execution permission.

Maybe you folks have a purpose for doing it. Although, I didn't find any explanation for it. Therefore, from my perspective, it seems to be a "bug". Please close this PR in case I am wrong.

This Pull Request updates the code in order to use the permission 0644 where we have:

Context

I was writing this Pull Request to Open Telemetry Collectors and realized that this tool (chloggen) was creating executable files under .chloggen/directory which seemed strange to me.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2aabfff) 63.65% compared to head (ba2b497) 63.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #457 +/- ## ======================================= Coverage 63.65% 63.65% ======================================= Files 39 39 Lines 2259 2259 ======================================= Hits 1438 1438 Misses 677 677 Partials 144 144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.