multimod: Fix tagging on Windows

open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories

https://opentelemetry.io

Apache License 2.0

32 stars 35 forks source link

multimod: Fix tagging on Windows #465

Closed scorpionknifes closed 10 months ago

scorpionknifes commented 10 months ago

Fixes #464

moduleFilePathToTagName() produces the following on Windows due to Windows file path using backslashes instead of slashes.

could not retrieve tag names from module paths: could not convert module file paths to tag names: could not convert module file path to tag name: modFilePath C:\...\test\test1\go.mod not contained in repo with root C:\...\

filePathToRegex() failing as filepath.Separator() in Windows is a backslash instead of the expected slash.

multimod unit test now passes on Windows with this PR

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (815fbfc) 63.72% compared to head (bdbe841) 63.78%.

Files	Patch %	Lines
multimod/internal/common/conversions.go	87.50%	0 Missing and 1 partial :warning:
multimod/internal/common/tools.go	80.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #465 +/- ## ========================================== + Coverage 63.72% 63.78% +0.06% ========================================== Files 39 39 Lines 2263 2267 +4 ========================================== + Hits 1442 1446 +4 Misses 677 677 Partials 144 144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scorpionknifes commented 10 months ago

LGTM. @scorpionknifes would you be interested in adding CI tests running on Windows to this repository?

Sounds good I'll do it as part of #450 I do need PR #448 for all the tests to pass in Windows, appreciate if anyone can review that one too :pray: