Closed scorpionknifes closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c1a2749
) 63.78% compared to head (c7185f3
) 63.78%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like multimod diff
isn't working on Windows, always thought it was an issue with my local git
multimod diff -m tools -p 1.2.3
error running diff: VerifyWorkingTreeClean failed: working tree not clean
Related issue with go-git https://www.github.com/go-git/go-git/issues/691 :eyes:
I suggest adding something like
if runtime.GOOS == "windows" {
t.Skip("diff does not work on Windows. Tracked under: https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/467.")
}
to TestHasChanged
unless you find a quick way to solve https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/467
Resolves #450 Resloves https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/451