open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories
https://opentelemetry.io
Apache License 2.0
32 stars 35 forks source link

[chore] Run lint and test-race GitHub jobs on Windows #466

Closed scorpionknifes closed 9 months ago

scorpionknifes commented 10 months ago

Resolves #450 Resloves https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/451

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c1a2749) 63.78% compared to head (c7185f3) 63.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #466 +/- ## ======================================= Coverage 63.78% 63.78% ======================================= Files 39 39 Lines 2267 2267 ======================================= Hits 1446 1446 Misses 677 677 Partials 144 144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scorpionknifes commented 9 months ago

Looks like multimod diff isn't working on Windows, always thought it was an issue with my local git

multimod diff -m tools -p 1.2.3
error running diff: VerifyWorkingTreeClean failed: working tree not clean

Related issue with go-git https://www.github.com/go-git/go-git/issues/691 :eyes:

pellared commented 9 months ago

I suggest adding something like

if runtime.GOOS == "windows" {
  t.Skip("diff does not work on Windows. Tracked under: https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/467.")
}

to TestHasChanged unless you find a quick way to solve https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/467