open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories
https://opentelemetry.io
Apache License 2.0
32 stars 35 forks source link

multimod: diff command errors run Windows #467

Open scorpionknifes opened 9 months ago

scorpionknifes commented 9 months ago

Running multimod diff fails on clean worktree on Windows

> multimod diff -m tools -p 1.2.3 
error running diff: VerifyWorkingTreeClean failed: working tree not clean

Related issues with go-git: https://github.com/go-git/go-git/issues/691 https://github.com/open-telemetry/opentelemetry-go-build-tools/blob/ff1ce4b48df82b450ee7233d0227454ed76d159c/multimod/internal/common/git.go#L147-L150

Related tests failing: https://github.com/open-telemetry/opentelemetry-go-build-tools/actions/runs/7216411029/job/19662557783?pr=466 Originally posted: https://github.com/open-telemetry/opentelemetry-go-build-tools/pull/466#issuecomment-1857125400