open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories
https://opentelemetry.io
Apache License 2.0
32 stars 35 forks source link

[chore] Bump Go to 1.20 #475

Closed webstradev closed 9 months ago

webstradev commented 9 months ago

Fixes #474

I updated all the go mods and corresponding tests to 1.20

linux-foundation-easycla[bot] commented 9 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (41b2c05) 63.78% compared to head (a69f7b5) 63.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #475 +/- ## ======================================= Coverage 63.78% 63.78% ======================================= Files 39 39 Lines 2267 2267 ======================================= Hits 1446 1446 Misses 677 677 Partials 144 144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bryan-aguilar commented 9 months ago

Weird, looks like the requirement is coming from this PR. https://github.com/open-telemetry/opentelemetry-go-build-tools/pull/466

This seems like such an odd behavior from GitHub, adding the requirement to a separate PR before the originating PR has been merged. Looks like we will have to wait for #466 to be merged.

pellared commented 9 months ago

@bryan-aguilar can you review #466? It awaits a review from someone who is not a Splunk employee.