Closed andreasgerstmayr closed 7 months ago
I can update this PR to sort the entries by Component and Note if we want them sorted.
Sorting would be great but let's keep it as a separate PR
I've dropped the external dependency now, and reverted some of the summary.tmpl
changes, to keep it as simple as it was before.
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
ad9317a
) 63.89% compared to head (1f9e485
) 63.76%.
Files | Patch % | Lines |
---|---|---|
chloggen/internal/chlog/summary.go | 90.32% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks good to me. We will need a changelog entry though :)
This looks good to me. We will need a changelog entry though :)
:smiley: Done. Thanks for the review!
Support providing a custom
summary.tmpl
file.@djaglowski is this what you had in mind for https://github.com/open-telemetry/opentelemetry-go-build-tools/pull/489#pullrequestreview-1866260923?
I didn't update any test input or output, so if everything is covered by unit tests, this PR shouldn't change the formatting of any existing changelog.
I noticed the lines here: https://github.com/open-telemetry/opentelemetry-go-build-tools/blob/ad9317af74bb648efb5b3f0c19b4697f0b468e65/chloggen/internal/chlog/summary.go#L57-L61 don't sort the changelog entries (
sort.Strings
should be used to sort them). I can update this PR to sort the entries byComponent
andNote
if we want them sorted.Resolves #488 Resolves #487