search

open-telemetry / opentelemetry-go-build-tools

Build tools for use by the Go API/SDK, the collector, and their associated contrib repositories
https://opentelemetry.io
Apache License 2.0
32 stars 35 forks source link

refactor: fix gosec linter G301 issue #593

Closed andrzej-stencel closed 1 month ago

andrzej-stencel commented 1 month ago

The G301 rule was updated to check for os.ModePerm in v1.58.2: https://github.com/securego/gosec/pull/1138.

This unblocks the upgrade of Go linter from v1.58.1 to a later version.

Example of a failure on linter upgrade PR https://github.com/open-telemetry/opentelemetry-go-build-tools/pull/574:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.74%. Comparing base (1ccc87b) to head (4a5595f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #593 +/- ## ======================================= Coverage 60.74% 60.74% ======================================= Files 40 40 Lines 1969 1969 ======================================= Hits 1196 1196 Misses 626 626 Partials 147 147 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.